Add maximum-height jump policy - #11

You have reached your Codex usage limits for security reviews. Please try again later.

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

hey @ThomasBurgess2000, thank you so much for adding this move to the registry - it’s our first external contribution 🎉 it genuinely means a lot to me.

if you (or your AI agent haha) have a minute, i'd love to hear how the contribution experience went: was anything confusing or annoying, did you get stuck anywhere, or was there anything you expected this registry to do that it didn't?

also curious what made you decide to add your policy here in the first place. no need for a detailed answer - any feedback would be super useful :)

hey @ob1-s ! I just saw your message in discord about this project and told 5.6 Sol to try and add the policy I had trained to it for fun :) I asked it if there were any notes for the maintainer re: things that would have made the contribution easier:

1. Fix and document pnpm cli submit.
   The command exists but is not mentioned in CONTRIBUTING.md. It commits only the behavior descriptor and says CI will rebuild the catalog, but CI fails when the regenerated public/registry.json is not committed. It should produce a complete, CI-passing PR or clearly be labeled descriptor-only.

2. Add a descriptor scaffold and aggregate preflight.
   A command such as pnpm cli init <id> could generate the fixed 61D/14-action contract and prompt for licensing, verification, artifacts, command semantics, and media. A second command should run validation, tests, compilation, and build together.

3. Make artifact validation match the CI job’s name.
   “Validate Registry & Artifacts” currently validates primarily the JSON schema. Useful additional checks would include:

   • Artifact URL accessibility and content type
   • Optional SHA-256 checksums
   • ONNX input/output dimensions (61 → 14)
   • Local media-file existence
   • Video codec and decode checks

4. Document and automate the media contract.
   CONTRIBUTING.md does not explain loop_url versus video_url, recommended duration, codec, aspect ratio, file location, or size limits. PR Add maximum-height jump policy #11 initially used one 20-second slow-motion video for both; a separate short card loop was added later. A media-preparation command could generate both automatically.

5. Generate the README catalog.
   The README’s behavior count and list are a second manually maintained source of truth. They should be generated from the descriptors alongside public/registry.json.

6. Unify the PR template and generated PR body.
   The CLI and .github/PULL_REQUEST_TEMPLATE.md currently use different checklists. A shared template could include sections for preview media, artifact provenance, verification evidence, command semantics, and known limitations.

7. Define a standard release manifest.
   A small release.json format could describe the canonical ONNX, checksum, license, source revision, metrics, media, and optional companion policies. The registry CLI could consume it to generate most of the descriptor automatically.

8. Document first-time fork CI approval.
   The workflow correctly waited for maintainer approval, but contributors should be told to expect the action_required state.

hey, just wanted to thank you again for the feedback :)

I just merged an onboarding overhaul - turned out the cli bloat was most of the friction, so it's gone for now. agents can just do their stuff

also, your policy has its own page now: https://uduckmoves.com/behaviors/max-height-jump

(every policy/behavior link gets its own Open Graph card with a randomized duck pose 🦆)